Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove go.mod replace with real version #15142

Merged
merged 1 commit into from
Nov 6, 2024
Merged

remove go.mod replace with real version #15142

merged 1 commit into from
Nov 6, 2024

Conversation

krehermann
Copy link
Contributor

The local replace is making my life miserable in downstream repos. multiple failed build requiring manual hunting and pecking for the right go get incantations

@krehermann krehermann requested review from a team as code owners November 6, 2024 22:01
@krehermann krehermann force-pushed the chore/no-deployment-gomod-replase branch from 3bf58ff to 6c29721 Compare November 6, 2024 22:04
@krehermann krehermann requested a review from a team as a code owner November 6, 2024 22:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@krehermann krehermann requested a review from jmank88 November 6, 2024 22:06
@krehermann krehermann enabled auto-merge November 6, 2024 22:06
jmank88
jmank88 reviewed Nov 6, 2024
View reviewed changes
core/scripts/go.mod
@@ -26,7 +26,7 @@ require (
github.com/smartcontractkit/chainlink-automation v0.8.1
github.com/smartcontractkit/chainlink-common v0.3.1-0.20241101093830-33711d0c3de7
github.com/smartcontractkit/chainlink/deployment v0.0.0-00010101000000-000000000000
github.com/smartcontractkit/chainlink/v2 v2.0.0-00010101000000-000000000000
github.com/smartcontractkit/chainlink/v2 v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar: why is our pseudo version 2.14 based? We just tagged through 2.18 the other day.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chainchad

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've been wondering this too but haven't bubbled it up. thanks for calling it out

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@krehermann krehermann added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit d61ce51 Nov 6, 2024
140 of 141 checks passed
@krehermann krehermann deleted the chore/no-deployment-gomod-replase branch November 6, 2024 23:26
krehermann added a commit that referenced this pull request Nov 7, 2024
@krehermann
Revert "remove go.mod replace with real version (#15142)"
fc33f00 
This reverts commit d61ce51.
@krehermann krehermann mentioned this pull request Nov 7, 2024
Merged
4of9 pushed a commit that referenced this pull request Nov 8, 2024
@krehermann @4of9
Revert "remove go.mod replace with real version (#15142)"
714656a 
This reverts commit d61ce51.
jmank88 pushed a commit that referenced this pull request Nov 8, 2024
@krehermann @jmank88
Revert "remove go.mod replace with real version (#15142)"
5eaf482 
This reverts commit d61ce51.
patrickhuie19 pushed a commit that referenced this pull request Nov 8, 2024
@krehermann
Revert "remove go.mod replace with real version (#15142)" (#15149)
1757514 
This reverts commit d61ce51.
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
@pkcll @4of9
@cll-gg @jmank88 @patrickhuie19 @krehermann
Beholder CSA Authentication (#15160)
816dcf8 
* Bump chainlink-common to PR latest

* Wire up Beholder auth in loop

* Move keystore auth into NewApplication

* Wire up CSA Auth for Beholder

* Use simplified auth header approach

* Add auth header after logging config

* Remove empty line for linter

* Put back mistakenly removed imports

* Update to latest chainlink-common@INFOPLAT-1071-beholder-csa-signer-auth_2

* Rename return vars

Co-authored-by: Jordan Krage <[email protected]>

* Bump chainlink-common from latest INFOPLAT-1071-beholder-csa-signer-auth_2

* Bump chainlink-common to latest INFOPLAT-1071-beholder-csa-signer-auth_2

* Bump chainlink-common to latest INFOPLAT-1071-beholder-csa-signer-auth_2

* go mod tidy for ./integration-tests

* make gomodtidy

* Add changeset file

* Potential test fix

* Clean up the test: remove a few unused mocks

* Revert "Clean up the test: remove a few unused mocks"

This reverts commit f55cc8e.

* Revert "Potential test fix"

This reverts commit cb348aa.

* Adding InstanceAppFactoryWithKeystoreMock for shell_local tests (#15167)

* Revert "remove go.mod replace with real version (#15142)"

This reverts commit d61ce51.

* Run go mod tidy

* Add Beholder auth to deployment LoopRegistry

* Update chainlink-common to PR latest

* Run go mod tidy

* Prep keystore for beholder auth

* Bump chainlink-common to latest

* Run go mod tidy

---------

Co-authored-by: 4of9 <[email protected]>
Co-authored-by: Geert G <[email protected]>
Co-authored-by: Jordan Krage <[email protected]>
Co-authored-by: patrickhuie19 <[email protected]>
Co-authored-by: krehermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@connorwstein connorwstein connorwstein approved these changes

@reductionista reductionista Awaiting requested review from reductionista reductionista is a code owner automatically assigned from smartcontractkit/foundations

@cgruber cgruber Awaiting requested review from cgruber

@AKhozya AKhozya Awaiting requested review from AKhozya

@kalverra kalverra Awaiting requested review from kalverra

@chainchad chainchad Awaiting requested review from chainchad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krehermann @jmank88 @connorwstein