Revert "remove go.mod replace with real version" #15149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
previously approved these changes
Nov 7, 2024
chainchad
previously approved these changes
Nov 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This reverts commit d61ce51.
jmank88
force-pushed
the
revert-15142-chore/no-deployment-gomod-replase
branch
from
fc33f00 to
5eaf482
Compare
|
Rebased since the merge result was not tidy. |
jmank88
approved these changes
Nov 8, 2024
jmank88
reviewed
Nov 8, 2024
| @@ -23,7 +23,7 @@ require ( | |||
| github.com/smartcontractkit/chainlink-testing-framework/wasp v1.50.2 | |||
| github.com/smartcontractkit/chainlink/deployment v0.0.0-00010101000000-000000000000 | |||
| github.com/smartcontractkit/chainlink/integration-tests v0.0.0-20241030133659-9ec788e78b4f | |||
| github.com/smartcontractkit/chainlink/v2 v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a | |||
| github.com/smartcontractkit/chainlink/v2 v2.9.0-beta0.0.20240216210048-da02459ddad8 | |||
There was a problem hiding this comment.
This is odd, but has no effect given the local replaces 🤔
connorwstein
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15142
this was good for external repos, but this repo has other local replaces than make it untenable without more thought about version pinning