-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sei testnet #1585
Closed
Closed
Add Sei testnet #1585
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
ChainID = '1328' | ||
ChainType = 'sei' | ||
# finality_depth: instant | ||
FinalityDepth = 10 | ||
# block_time: ~0.4s, adding 1 second buffer | ||
LogPollInterval = '2s' | ||
# finality_depth * block_time / 60 secs = ~0.8 min (finality time) | ||
NoNewFinalizedHeadsThreshold = '5m' | ||
# "RPC node returned multiple missing blocks on query for block numbers [31592085 31592084] even though the WS subscription already sent us these blocks. It might help to increase EVM.RPCBlockQueryDelay (currently 1)" | ||
RPCBlockQueryDelay = 5 | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = false | ||
Mode = 'BlockHistory' | ||
|
||
[GasEstimator.BlockHistory] | ||
BlockHistorySize = 200 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,6 +144,7 @@ func Test_Eth_Errors(t *testing.T) { | |
{"client error transaction already in mempool", true, "tomlConfig"}, | ||
{"alreadyknown", true, "Gnosis"}, | ||
{"failed to forward tx to sequencer, please try again. Error message: 'already known'", true, "Mantle"}, | ||
{"tx already exists in cache", true, "Sei"}, | ||
} | ||
for _, test := range tests { | ||
err = evmclient.NewSendErrorS(test.message) | ||
|
@@ -420,6 +421,11 @@ func Test_Eth_Errors_Fatal(t *testing.T) { | |
{"client error fatal", true, "tomlConfig"}, | ||
{"[Request ID: d9711488-4c1e-4af2-bc1f-7969913d7b60] Error invoking RPC: transaction [email protected] failed precheck with status INVALID_SIGNATURE", true, "hedera"}, | ||
{"invalid chain id for signer", true, "Treasure"}, | ||
|
||
{": out of gas", true, "Sei"}, | ||
{"Tx too large. Max size is 2048576, but got 2097431", true, "Sei"}, | ||
{": insufficient funds", true, "Sei"}, | ||
{"insufficient fee", true, "Sei"}, | ||
} | ||
|
||
for _, test := range tests { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically don't add a new chain type, unless it's type is needed to create some chain specific custom code.
For example, see this method that does custom code per chaintype: https://github.com/smartcontractkit/chainlink/blob/101fbbc75a76893d2ebe0c24fa61773876007d76/core/chains/evm/gas/chain_specific.go#L11-L60
If you haven't identified any custom code needed for Sei, then no need to create a new type here.
Atleast in this PR, I don't see any custom code added that acted on this new chaintype.