Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sei testnet #1585

Closed
wants to merge 4 commits into from
Closed

Add Sei testnet #1585

wants to merge 4 commits into from

Conversation

flodesi
Copy link
Collaborator

@flodesi flodesi commented Jan 3, 2025

Motivation

As part of an ongoing integration effort, adding Sei testnet config to ccip

Solution

@flodesi flodesi requested a review from a team January 3, 2025 15:41
@flodesi flodesi requested a review from a team as a code owner January 3, 2025 15:41
@@ -22,6 +22,7 @@ const (
ChainXLayer ChainType = "xlayer"
ChainZkEvm ChainType = "zkevm"
ChainZkSync ChainType = "zksync"
ChainSei ChainType = "sei"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't add a new chain type, unless it's type is needed to create some chain specific custom code.
For example, see this method that does custom code per chaintype: https://github.com/smartcontractkit/chainlink/blob/101fbbc75a76893d2ebe0c24fa61773876007d76/core/chains/evm/gas/chain_specific.go#L11-L60

If you haven't identified any custom code needed for Sei, then no need to create a new type here.
Atleast in this PR, I don't see any custom code added that acted on this new chaintype.

@prashantkumar1982
Copy link
Contributor

I haven't worked on the ccip branch before.
We always used to make changes to these files in the chainlink repo.
Do you know why you need to make these changes in the ccip branch?
Can you validate with the CCIP team, what is the right approach? I thought ccip team only used to merge from chainlink repo to ccip, not the other way.

@flodesi flodesi closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants