Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.search: reject promise on undefined result #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Client.search: reject promise on undefined result #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ Client.prototype.search = function (base, options, controls) {

return new Promise(function (resolve, reject) {
var searchCallback = function (err, result) {
if (result === undefined) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference for checking for no result, vs checking for the presence of an error?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check line 59 - there at least some cases where result provides an error event, in which case the err value is consulted. In this case, there is no result.

reject(err);
}

var r = {
entries: [],
references: []
Expand Down