Client.search: reject promise on undefined result #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
reject_on_null_result
branch
from
90e7f56 to
cdf8b8d
Compare
| @@ -39,6 +39,10 @@ Client.prototype.search = function (base, options, controls) { | |||
|
|
|||
| return new Promise(function (resolve, reject) { | |||
| var searchCallback = function (err, result) { | |||
| if (result === undefined) { | |||
There was a problem hiding this comment.
Is there a difference for checking for no result, vs checking for the presence of an error?
There was a problem hiding this comment.
Check line 59 - there at least some cases where result provides an error event, in which case the err value is consulted. In this case, there is no result.
technicalpickles
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug we'd noticed where certain upstream errors are handled by returning only a single result, instead of two. We were seeing unexpectedly-handled promises as a result of this.