-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Support NumPy 2 #2934
[python] Support NumPy 2 #2934
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
+ Coverage 83.22% 83.33% +0.10%
==========================================
Files 51 51
Lines 5462 5462
==========================================
+ Hits 4546 4552 +6
+ Misses 916 910 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Oddly, the "Show package versions" bit in
🤔 |
441dae6
to
662dd01
Compare
I just pushed a rebase. Good news: this time (unlike before) we do get numpy 2
|
ef117ae
to
ce860c5
Compare
Trying to add @kounelisagis as a reviewer ... |
ce860c5
to
03eb9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* [python] NumPy 2 experiment [WIP] * fixups from latest CI run
* [python] NumPy 2 experiment [WIP] * fixups from latest CI run Co-authored-by: John Kerl <[email protected]>
Issue and/or context: #2536
Changes:
Notes for Reviewer:
Main thing to watch for: NumPy 2.0 does not support Python 3.8, while we have not yet dropped support for Python 3.8 (#2141).
Per https://github.com/numpy/numpy/releases/tag/v2.0.0:
I thought we'd need a bit in
setup.py
likebut in hindsight it seems not -- a Python 3.8 asking to get NumPy will simply not be offered version 2 in the first place 😎