Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually migrate to numpy 2 #220

Closed
wants to merge 6 commits into from
Closed

Conversation

jdblischak
Copy link
Collaborator

I missed yesterday (#218) that 1.15.0rc3 added support for numpy 2. Since this feedstock isn't part of conda-forge, we need to manually migrate tiledbsoma-feedstock to numpy 2, just like we are doing for tiledb-vcf-feedstock (TileDB-Inc/tiledb-vcf-feedstock#141 (review))

@jdblischak
Copy link
Collaborator Author

Well I'm stuck. We get a conda solver error trying to use numpy2 with our cloud variant (built with outdated pins).

Locally I tried various combinations of defining python, numpy, and python_impl in conda_build_config.yaml, but nothing worked. At this point I don't think we can migrate this feedstock to numpy 2 until we drop the cloud variant (at least not without implementing a hacky workaround that would require manual intervention after each conda-smithy rerendering).

@jdblischak
Copy link
Collaborator Author

@ihnorton confirmed that we will drop the py39 environment when we transition the cloud to py312+numpy2. Thus the goal of this PR is to test that the feedstock transition to numpy2 will go smoothly in the future when the py39 cloud variant is dropped

@jdblischak
Copy link
Collaborator Author

Hmmm...it appears that the fmt 11 and spdlog 1.14 migrations are stalled. I'll have to manually apply these to the feedstock since they haven't made it to conda-forge-pinning yet

@jdblischak
Copy link
Collaborator Author

Also cross-referencing upstream support for numpy 2: single-cell-data/TileDB-SOMA#2536, single-cell-data/TileDB-SOMA#2934

@jdblischak
Copy link
Collaborator Author

Went with the 2-branch approach. Superseded by #227 and #228

@jdblischak jdblischak closed this Nov 19, 2024
@jdblischak jdblischak deleted the numpy2 branch November 19, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant