loongarch float16: use a portable version to avoid compilation errors #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
force-pushed
the
loongarch_float16
branch
from
6b0476f to
acdbc40
Compare
mr-c
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
That the new CI job catches the error is confirmed at https://github.com/simd-everywhere/simde/actions/runs/10972598018/job/30469053422#step:9:11
Thank you for the fix @XiWeiGu !
mr-c
force-pushed
the
loongarch_float16
branch
from
fdb8896 to
f00e47f
Compare
mr-c
force-pushed
the
loongarch_float16
branch
from
f00e47f to
464a748
Compare
mr-c
force-pushed
the
loongarch_float16
branch
from
464a748 to
5345434
Compare
wszqkzqk
added a commit
to wszqkzqk/WebKit
that referenced
this pull request
Nov 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=280505 simd-everywhere/simde#1224 Reviewed by NOBODY (OOPS!). Fixed the compilation issue on the Loongarch platform with clang: ` ../test/x86/avx512/../../../simde/simde-f16.h:100:11: error: _Float16 is not supported on this target.` * Source/WTF/wtf/simde/arm/neon.h: use a portable version to avoid compilation errors in loongarch's float16
wszqkzqk
added a commit
to wszqkzqk/WebKit
that referenced
this pull request
Nov 27, 2024
…x for loong64 platform https://bugs.webkit.org/show_bug.cgi?id=280505 simd-everywhere/simde#1224 Reviewed by NOBODY (OOPS!). Synchronize sources about LASX from BUILD.gn to CMakeList.txt to fix error during linking on loong64 platform, like: `ld.lld: error: undefined hidden symbol: SkOpts::Init_lasx()` Fixed the compilation issue on the loong64 platform with clang: ` ../test/x86/avx512/../../../simde/simde-f16.h:100:11: error: _Float16 is not supported on this target.` * Source/ThirdParty/skia/CMakeLists.txt: Add: src/core/SkBitmapProcState_opts_lasx.cpp src/core/SkBlitRow_opts_lasx.cpp src/core/SkSwizzler_opts_lasx.cpp src/opts/SkOpts_lasx.cpp * Source/WTF/wtf/simde/arm/neon.h: use a portable version to avoid compilation errors in loongarch's float16
wszqkzqk
added a commit
to wszqkzqk/WebKit
that referenced
this pull request
Nov 28, 2024
…d with clang https://bugs.webkit.org/show_bug.cgi?id=280505 simd-everywhere/simde#1224 Reviewed by NOBODY (OOPS!). Fixed the compilation issue on the Loongarch platform with clang: ` ../test/x86/avx512/../../../simde/simde-f16.h:100:11: error: _Float16 is not supported on this target.` * Source/WTF/wtf/simde/arm/neon.h: use a portable version to avoid compilation errors in loongarch's float16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the compilation issue on the Loongarch platform with clang:
../test/x86/avx512/../../../simde/simde-f16.h:100:11: error: _Float16 is not supported on this target.