Skip to content

Commit

Permalink
Synchronize sources of LASX to CMakeList.txt and back port simde's fi…
Browse files Browse the repository at this point in the history
…x for loong64 platform

https://bugs.webkit.org/show_bug.cgi?id=280505
simd-everywhere/simde#1224

Reviewed by NOBODY (OOPS!).

Synchronize sources about LASX from BUILD.gn to CMakeList.txt
to fix error during linking on loong64 platform, like:

`ld.lld: error: undefined hidden symbol: SkOpts::Init_lasx()`

Fixed the compilation issue on the loong64 platform with clang:

` ../test/x86/avx512/../../../simde/simde-f16.h:100:11: error: _Float16 is not supported on this target.`

* Source/ThirdParty/skia/CMakeLists.txt:
Add:
src/core/SkBitmapProcState_opts_lasx.cpp
src/core/SkBlitRow_opts_lasx.cpp
src/core/SkSwizzler_opts_lasx.cpp
src/opts/SkOpts_lasx.cpp
* Source/WTF/wtf/simde/arm/neon.h:
use a portable version to avoid compilation errors in loongarch's float16
  • Loading branch information
wszqkzqk committed Nov 27, 2024
1 parent 3be0078 commit fb61eb0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Source/ThirdParty/skia/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -182,13 +182,15 @@ add_library(Skia STATIC
src/core/SkBitmapProcState_matrixProcs.cpp
src/core/SkBitmapProcState_opts.cpp
src/core/SkBitmapProcState_opts_ssse3.cpp
src/core/SkBitmapProcState_opts_lasx.cpp
src/core/SkBlendMode.cpp
src/core/SkBlendModeBlender.cpp
src/core/SkBlitMask_opts.cpp
src/core/SkBlitMask_opts_ssse3.cpp
src/core/SkBlitRow_D32.cpp
src/core/SkBlitRow_opts.cpp
src/core/SkBlitRow_opts_hsw.cpp
src/core/SkBlitRow_opts_lasx.cpp
src/core/SkBlitter.cpp
src/core/SkBlitter_A8.cpp
src/core/SkBlitter_ARGB32.cpp
Expand Down Expand Up @@ -344,6 +346,7 @@ add_library(Skia STATIC
src/core/SkSwizzler_opts.cpp
src/core/SkSwizzler_opts_hsw.cpp
src/core/SkSwizzler_opts_ssse3.cpp
src/core/SkSwizzler_opts_lasx.cpp
src/core/SkTaskGroup.cpp
src/core/SkTextBlob.cpp
src/core/SkTypeface.cpp
Expand Down Expand Up @@ -883,6 +886,7 @@ add_library(Skia STATIC

src/opts/SkOpts_hsw.cpp
src/opts/SkOpts_skx.cpp
src/opts/SkOpts_lasx.cpp

src/ports/SkGlobalInitialization_default.cpp
src/ports/SkImageGenerator_skia.cpp
Expand Down
1 change: 1 addition & 0 deletions Source/WTF/wtf/simde/arm/neon.h
Original file line number Diff line number Diff line change
Expand Up @@ -8788,6 +8788,7 @@ SIMDE_BEGIN_DECLS_
!(defined(HEDLEY_MSVC_VERSION) && defined(__clang__)) && \
!(defined(SIMDE_ARCH_MIPS) && defined(__clang__)) && \
!(defined(SIMDE_ARCH_ZARCH) && defined(__clang__)) && \
!(defined(SIMDE_ARCH_LOONGARCH) && defined(__clang__)) && \
!(defined(__clang__) && defined(SIMDE_ARCH_RISCV64)) && ( \
defined(SIMDE_X86_AVX512FP16_NATIVE) || \
(defined(SIMDE_ARCH_X86_SSE2) && HEDLEY_GCC_VERSION_CHECK(12,0,0)) || \
Expand Down

0 comments on commit fb61eb0

Please sign in to comment.