-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Counting should not interfere with iterator #74
base: 3.0
Are you sure you want to change the base?
Conversation
test is failing but not due to the pr right join should be supported in 2022-06-25 (3.39.0) so maybe it's just a matter of making sure we run the test on the latest version. not sure about the union failing but it also seems supported in recent version the test use 3.37.2 so probably a simple update should do the trick! |
Please target this to |
@GuySartorelli done i've also opened an issue on the gha-ci repository i think all it needs is a sudo apt install sqlite3 -y to get the updated binary but i didn't manage to test it properly :) |
anything else i can do for this ? :) |
Right now it's just waiting for someone to look at it properly and review it. It's not a high priority, so it could be a while. |
well, it's quite broken at the moment since it display things one extra time. If anyone is trying to use sqlite as a backend database, they are in for a bad surprise :-) |
Yup. But because this module isn't commercially supported for it's 3.x release line the CMS squad can't prioritise it above the commercially supported module issues we're working on. If you'd like to help maintain the 3.x line for this module to help get this fixed quicker, there are instructions for expressing your interest at https://docs.silverstripe.org/en/5/changelogs/5.0.0/#modules-not-supported-going-forward |
Fixes #73
See issue for context