Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counting should not interfere with iterator #74

Open
wants to merge 6 commits into
base: 3.0
Choose a base branch
from

Conversation

lekoala
Copy link
Collaborator

@lekoala lekoala commented Oct 24, 2023

Fixes #73
See issue for context

@lekoala
Copy link
Collaborator Author

lekoala commented Oct 24, 2023

test is failing but not due to the pr

right join should be supported in 2022-06-25 (3.39.0) so maybe it's just a matter of making sure we run the test on the latest version. not sure about the union failing but it also seems supported in recent version

the test use 3.37.2 so probably a simple update should do the trick!

@GuySartorelli
Copy link
Member

Please target this to 3.0 so it can be released as a patch

@lekoala lekoala changed the base branch from 3 to 3.0 October 26, 2023 07:55
@lekoala
Copy link
Collaborator Author

lekoala commented Oct 26, 2023

@GuySartorelli done

i've also opened an issue on the gha-ci repository
silverstripe/gha-ci#89

i think all it needs is a sudo apt install sqlite3 -y to get the updated binary but i didn't manage to test it properly :)

@lekoala
Copy link
Collaborator Author

lekoala commented Nov 7, 2023

anything else i can do for this ? :)

@GuySartorelli
Copy link
Member

Right now it's just waiting for someone to look at it properly and review it. It's not a high priority, so it could be a while.

@lekoala
Copy link
Collaborator Author

lekoala commented Nov 8, 2023

well, it's quite broken at the moment since it display things one extra time. If anyone is trying to use sqlite as a backend database, they are in for a bad surprise :-)

@GuySartorelli
Copy link
Member

Yup. But because this module isn't commercially supported for it's 3.x release line the CMS squad can't prioritise it above the commercially supported module issues we're working on.

If you'd like to help maintain the 3.x line for this module to help get this fixed quicker, there are instructions for expressing your interest at https://docs.silverstripe.org/en/5/changelogs/5.0.0/#modules-not-supported-going-forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iterator loop over the same item twice
3 participants