Iterator loop over the same item twice

[lekoala]

Just found a really odd issue when testing sqlite

in a template i have this

<% loop MyList %>
...
<% end_loop %>

The list contains only one record, but it's displayed twice

It seems due to the switch to generators We have yield $data, but that is actually called twice due to the rewind call in SSViewer_scope.
I don't have a solution yet. Removing $this->itemIterator->rewind(); fixes the issue, but it's probably there for a reason.

Also, with sqlite, fetchArray can start giving AGAIN the results after false has been returned, so that might also be it, or a combination of both issues.

PRs

• Counting should not interfere with iterator #74

[lekoala]

so i think i got the general idea. The issue happens here

https://github.com/silverstripe/silverstripe-framework/blob/64e2b5e48981d68487a5be34b287018dcd6a482a/src/View/SSViewer_Scope.php#L303-L313

• we get the iterator and the first row (yield)
• we count it using numRecords in the DataList, but that reset the handle to the first row

https://github.com/silverstripe/silverstripe-framework/blob/64e2b5e48981d68487a5be34b287018dcd6a482a/src/ORM/DataList.php#L1502-L1509

• the first row is iterated again

working on a fix :)

[lekoala]

so i have a solution
not sure it's the best one, but at least it's working :)

[GuySartorelli]

This will need to wait until actions/runner-images#9033 is resolved so we can use a compatible version of sqlite3 in CI

[lekoala]

@GuySartorelli well, the ci is not needed to confirm that my fix works :-) but i'm in no rush, no issues with running my own little fork in the meantime