ENH Rename and move Title field #207
Conversation
emteknetnz
force-pushed
the
pulls/4/title-field
branch
from
7542172 to
506c81c
Compare
| * @return void | ||
| * @dataProvider linkUrlCasesDataProvider | ||
| */ | ||
| public function testGetUrl(string $identifier, string $class, string $expected): void |
There was a problem hiding this comment.
This is unrelated refactoring to move the data provider above the unit test to match the rest of the file
| @@ -241,7 +227,21 @@ public function linkUrlCasesDataProvider(): array | |||
| ]; | |||
| } | |||
|
|
|||
| function linkDefaultTitleDataProvider(): array | |||
There was a problem hiding this comment.
This is unrelated refactoring to rename this to provideGetUrl() to match our conventions
| @@ -303,7 +303,7 @@ function linkDefaultTitleDataProvider(): array | |||
| } | |||
|
|
|||
| /** | |||
| * @dataProvider linkDefaultTitleDataProvider | |||
| * @dataProvider provideDefaultLinkTitle | |||
There was a problem hiding this comment.
This is unrelated refactoring to get this to match our naming conventions
emteknetnz
force-pushed
the
pulls/4/title-field
branch
from
506c81c to
462dd2d
Compare
| LINK_TYPE_TITLE: 'Link Type' | ||
| MISSING_DEFAULT_TITLE: 'No link provided' | ||
| MISSING_DEFAULT_TITLE: '(No value provided)' |
There was a problem hiding this comment.
Since we're now always showing a title, this was the default provided for custom links without LinkText - I've updated it to something more sensible since it's more likely the custom link have a "value" rather that a "link (to a relation)"
emteknetnz
force-pushed
the
pulls/4/title-field
branch
from
462dd2d to
3fdf9e5
Compare
| @@ -30,26 +30,26 @@ en: | |||
| FILE_DOES_NOT_EXIST: 'File does not exist' | |||
| FILE_FIELD: File | |||
| LINKLABEL: 'Link to a file' | |||
| MISSING_DEFAULT_TITLE: 'File missing' | |||
| MISSING_DEFAULT_TITLE: '(File missing)' | |||
There was a problem hiding this comment.
This is unrelated refactoring to add brackets to "File missing" and "Page missing" default titles so that it matches "(No value provided)" for generic links
It's just a little something to make it really obvious that it's not regular link text
| @@ -81,10 +81,10 @@ public function testLinkFormGetSchema( | |||
| . "&ownerRelation=$ownerRelation"; | |||
| $this->assertSame($expectedAction, $formSchema['schema']['action']); | |||
| // schema is nested and retains 'Root' and 'Main' tab hierarchy | |||
| $this->assertSame('Phone', $formSchema['schema']['fields'][0]['children'][0]['children'][1]['name']); | |||
| $this->assertSame('Phone', $formSchema['schema']['fields'][0]['children'][0]['children'][0]['name']); | |||
There was a problem hiding this comment.
These array index changes are required because we're move LinkText to the bottom in getCMSFields()
emteknetnz
force-pushed
the
pulls/4/title-field
branch
from
3fdf9e5 to
3a8e7c6
Compare
emteknetnz
force-pushed
the
pulls/4/title-field
branch
from
3a8e7c6 to
4e43d54
Compare
I fixed a few issues at once because it made sense because they're very closely related
The general approach of this PR was to update PHP change 'Title' to 'LinkText', though JS was left completely alone and still uses 'title'
Also in the XHR request to get linkData, there is now always a populated 'Title' field returned that returns getTitle().
This means we'll never have a empty title field unless someone puts in custom code to have a blank default title in which case it'll still have the unclickable area, though that's such an edge case I don't think we need to worry about it,
Issues
Titlefield #179getDisplayTitletogetTitle#128