Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and rename Title field #179

Closed
purplespider opened this issue Jan 18, 2024 · 4 comments
Closed

Move and rename Title field #179

purplespider opened this issue Jan 18, 2024 · 4 comments

Comments

@purplespider
Copy link

purplespider commented Jan 18, 2024

In the modals, could I suggest moving the field for the linked item to the top, so it's the first item a user sees, and then the optional extra fields like "Title" and "Open in new window?" below it?

Before:
external-before

After:
external-after

For context, the WYSIWYG has the link text field below the URL or equivalent fields:
image

Acceptance criteria

  • "Title" label is rename "Link text".
  • DB field is renamed LinkText.
  • Developers migrating from older version of the module can get their Title converted to LinkText and have clear guidance about how to do that.
  • "Link text" is de-prioritise.
  • "Link text" warning is switched to use the "Hint" API.

Note

There's an API that got introduced in CMS4 to rename DB Fields to something else. It should still be there in CMS 5 and could be used to migrate Title to LinkText.

PR

@emteknetnz
Copy link
Member

That makes sense to me. We'll bring this issue into our team refinement to discuss

@maxime-rainville
Copy link

We had a discussion about this and we're 100% sure this is a beneficial change. We'll have a chat with our UX team to discuss what makes most sense.

The Title field is a bit unconventional in this context. So maybe we want to have an overarching discussion about it

@maxime-rainville
Copy link

Following discussion with Cassie, we concluded:

  • Renaming "Title" to "Link text" would be advisable. (I don't think we need to rename the underlying DB field)
  • The order from the WYSIWYG is better to the current order.

@GuySartorelli GuySartorelli changed the title Modal field order: Move linked item field to first position? Move and rename Title field Feb 6, 2024
@emteknetnz emteknetnz self-assigned this Feb 7, 2024
@emteknetnz emteknetnz removed their assignment Feb 8, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants