MNT Use FQCN for PHP translations #164
Conversation
|
Small question, should we also update en.yml file? Or will it have been updated automatically? |
emteknetnz
force-pushed
the
pulls/4/namespace
branch
from
4caf76b to
a36650c
Compare
|
Good point. I've just run the text collector task on linkfield and committed the results |
| UPDATE_LINK: 'Update link' | ||
| VERSIONED_STATUS_MISMATCH: 'Linkable and LinkField do not have matching Versioned applications. Make sure that both are either un-Versioned or Versioned' | ||
| SilverStripe\LinkField\Form\Traits\AllowedLinkClassesTrait: |
There was a problem hiding this comment.
Change references to these in the trait from __CLASS__ to be the FCQN of the trait hardcoded, because:
https://www.php.net/manual/en/language.constants.magic.php
When used in a trait method, CLASS is the name of the class the trait is used in.
In other words the call to _t() will pass in the name of the class (not the trait) - but here the key is the trait (not the class)
There was a problem hiding this comment.
Oh good spot :-)
Updated to use __TRAIT__ (have confirmed it works as expected)
There was a problem hiding this comment.
OH, nice! I should have looked at that list I linked to a little longer, I didn't notice that option.
emteknetnz
force-pushed
the
pulls/4/namespace
branch
from
a36650c to
a26d668
Compare
Issue #140
JS short classname namespace remains as it's the standard used in other modules e.g. admin