Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper namespace for PHP translation #140

Closed
maxime-rainville opened this issue Dec 13, 2023 · 2 comments
Closed

Use proper namespace for PHP translation #140

maxime-rainville opened this issue Dec 13, 2023 · 2 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Dec 13, 2023

We made the module localisable in #113

However we don't appear to be using our regular convention for PHP translation key.

e.g.:

This line

_t('LinkField.LINK_TYPE_TITLE', 'Link Type'),

should be written

_t(__CLASS__ . '.LINK_TYPE_TITLE', 'Link Type'),
// OR
_t(Link::class . '.LINK_TYPE_TITLE', 'Link Type'),

Acceptance criteria

  • All PHP translation keys use the standard approach used in other module.

PR

@GuySartorelli
Copy link
Member

@emteknetnz Can you please link to any relevant PRs in the description?

@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants