ENH Fallback to reading PHP version from composer.json #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/1.17/doorman
branch
from
8d7d601 to
10ad602
Compare
|
|
|
This is #115 - and CI is failing on it. |
emteknetnz
force-pushed
the
pulls/1.17/doorman
branch
from
037a730 to
ee86c41
Compare
emteknetnz
changed the title
emteknetnz
commented
Dec 9, 2024
| ['myaccount/silverstripe-admin', 'mybranch', ['silverstripe/framework' => '^6'], 'silverstripe-theme', '6.x-dev'], | ||
| ['myaccount/silverstripe-somemodule', 'mybranch', ['silverstripe/cms' => '^6'], 'silverstripe-recipe', '6.x-dev'], | ||
| ['myaccount/silverstripe-somemodule', 'mybranch', ['silverstripe/admin' => '^3'], 'silverstripe-vendormodule', '6.x-dev'], | ||
| ['myaccount/silverstripe-admin', 'mybranch', ['silverstripe/framework' => '^6'], 'silverstripe-theme', '6.0.x-dev'], |
There was a problem hiding this comment.
Changes here are in a separate commit to fix unrelated broken unit test
GuySartorelli
requested changes
Dec 9, 2024
emteknetnz
force-pushed
the
pulls/1.17/doorman
branch
from
ee86c41 to
8754dbb
Compare
GuySartorelli
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#350
Multiple commits, do not squash merge