-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace silverstripe/closure
with laravel/serializable-closure
#350
Comments
This was referenced Dec 4, 2024
The doorman runner in queuedjobs was the only place in sink that I could find usage of silverstripe/closure |
Assigning back to Steve to tag doorman |
PRs merged. Reassigning to Steve for any other ACs that need to be done |
All done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/silverstripe/closure/ was forked from https://github.com/opis/closure to address PHP compatibility concerns.
https://github.com/laravel/serializable-closure is a fork of the same repo, which is well maintained. It was a recommended replacement in opis/closure#145 (comment)
We should swap to using laravel/serializable-closure
Since they're both forks of the same package I think this could be sensibly done in a minor release.
Acceptance Criteria
silverstripe/closure
as a dependency useslaravel/serializable-closure
insteadsilverstripe/closure
is archived in GitHubsilverstripe/closure
is marked abandoned in Packagist with the recommendation to uselaravel/serializable-closure
insteadPRs
The text was updated successfully, but these errors were encountered: