Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace silverstripe/closure with laravel/serializable-closure #350

Closed
3 tasks done
GuySartorelli opened this issue Dec 3, 2024 · 4 comments
Closed
3 tasks done

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 3, 2024

https://github.com/silverstripe/closure/ was forked from https://github.com/opis/closure to address PHP compatibility concerns.

https://github.com/laravel/serializable-closure is a fork of the same repo, which is well maintained. It was a recommended replacement in opis/closure#145 (comment)

We should swap to using laravel/serializable-closure

Since they're both forks of the same package I think this could be sensibly done in a minor release.

Acceptance Criteria

  • Anywhere using silverstripe/closure as a dependency uses laravel/serializable-closure instead
  • silverstripe/closure is archived in GitHub
  • silverstripe/closure is marked abandoned in Packagist with the recommendation to use laravel/serializable-closure instead

PRs

@emteknetnz
Copy link
Member

The doorman runner in queuedjobs was the only place in sink that I could find usage of silverstripe/closure

@GuySartorelli
Copy link
Member Author

Assigning back to Steve to tag doorman

@GuySartorelli
Copy link
Member Author

PRs merged. Reassigning to Steve for any other ACs that need to be done

@emteknetnz
Copy link
Member

All done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants