Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uri): don't use full path for custom schema #1

Closed
wants to merge 1 commit into from
Closed

fix(uri): don't use full path for custom schema #1

wants to merge 1 commit into from

Commits on Aug 14, 2022

  1. fix(uri): don't use full path for custom schema 

    deno lsp uses a custom schema `deno:`

`uri_from_bufnr` returns the full path of the buf file but this doesn't work with custom schema

This fixes the last remaining  bug here <neovim/nvim-lspconfig#2005> `relative dependencies inside virtual text document is not resolved correctly`

Notes:
- maybe `if relative_name:match("deno:")` should become `if is_custom_schema(realtive_name)` where is_custom_schema matches `URI_SCHEME_PATTERN` but is not equal to `file:///`
- this changes fixes all my issues with denols (with some minor modifications that I can pr later)

This is more to start a discussion I thought showing code is easier to discuss then raising an issue
    @sigmaSd
    sigmaSd authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    3705519 View commit details
    Browse the repository at this point in the history