fix(uri): don't use full path for custom schema #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deno lsp uses a custom schema `deno:` `uri_from_bufnr` returns the full path of the buf file but this doesn't work with custom schema This fixes the last remaining bug here <neovim/nvim-lspconfig#2005> `relative dependencies inside virtual text document is not resolved correctly` Notes: - maybe `if relative_name:match("deno:")` should become `if is_custom_schema(realtive_name)` where is_custom_schema matches `URI_SCHEME_PATTERN` but is not equal to `file:///` - this changes fixes all my issues with denols (with some minor modifications that I can pr later) This is more to start a discussion I thought showing code is easier to discuss then raising an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deno lsp uses a custom schema
deno:uri_from_bufnrreturns the full path of the buf file but this doesn't work with custom schemaThis fixes the last remaining bug here neovim/nvim-lspconfig#2005
relative dependencies inside virtual text document is not resolved correctlyNotes:
if relative_name:match("deno:")should becomeif is_custom_schema(realtive_name)whereis_custom_schemais true for any schema that matchesURI_SCHEME_PATTERNbut is not equal tofile:///This is more to start a discussion I thought showing code is easier to discuss then raising an issue