Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D U-Net HipMRI s46978116 #183

Open
wants to merge 32 commits into
base: topic-recognition
Choose a base branch
from

Conversation

obbamna
Copy link

@obbamna obbamna commented Oct 31, 2024

2D U-Net Solution to Segmenting HipMRI Data

I am requesting to merge my solution to the 2D U-Net problem in COMP3710 Pattern Recognition Report. I implemented and trained a 2D U-Net to segmeent HipMRI data based on body parts. I have saved two models as well as various images regarding their performances. README.MD contains a report of the 2D U-Net's implementation and results.

Files

My pull request contains these files:

  • dataset.py

Provides functions and classes to load images from the HipMRI dataset found on RANGPUR. Replace folder path with your own path where necessary.

  • modules.py

Contains the Neural Networks that makes up the 2D U-Net

  • train.py

Trains a 2D U-Net from modules.py on data using the dataset class from dataset.py to load images in tensor form. Runs training for a number of epochs and generates and saves prediction images, training plots and loss performances.

  • predict.py

Runs a pre-trained model on the test set to evaluate it. Produces prediction images and dice co-efficients on test set.

  • README.MD

Contains a report of the entire project with output, theory, requirements and references.

  • images/

Folder containing images used in the report and the saved dice co-efficients.

  • savedmodels/

Folder containing two saved models that can be evaluated in predict.py

Not Included

HipMRI data has not been included, however it is necessary for training and evaluating and must be acquired independently. Replace necessary folder paths with your own path to this data.

@obbamna obbamna changed the title Topic recognition 2D U-Net HipMRI s46978116 Nov 1, 2024
@gayanku gayanku added the _UNet2D label Nov 1, 2024
@yexincheng
Copy link
Collaborator

yexincheng commented Nov 8, 2024

This is an initial inspection, no action is required at this point

  1. Solves problem: 4 labels achieved over 0.75 DICE score, 2 labels achieved nearly 0.75 DICE score. The tricks and experiments used for improving accuracy were well-documented in the readme. The loss plots and prediction figures can be found under the "images" folder; the image paths in the readme file need to be corrected. Overall, the problem is well-solved.
  2. Implementation: Some hypterparameters were hard-coded in the training script instead of using ArgParse. Otherwise all great.
  3. Design: well-designed.
  4. Comment: sufficient comments. The package requirement in the readme did not specify versions.
  5. Difficulty: Easy Difficulty.

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku gayanku added the _After cutoff After Oct 28th label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
Good solution to problem.
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Easy. UNet2D (Easy Difficulty)-10
Commit Log
Good Meaningful commit messages.
Good Progressive commits. Spans 2 days.-2
Documentation
Readme :Acceptable. No train graphs.-1
Model/technical explanation :Good.
Description and Comments :Good.
Markdown used and PDF submitted. PDF checked.
Pull Request
Pull Request has problems: Late submission.-2
Feedback action required: Feedback marks possible +2 if the requested changes are made. Remove model checkpoints for mearge.-2
Request Description is good.
TOTAL-18

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Feedback marks possible +2 if the requested changes are made (see above).

@gayanku gayanku added help wanted Extra attention is needed Preliminary Grade To be confirmed after review. Feedback Needed Feedback needed for completion. labels Nov 14, 2024
@obbamna
Copy link
Author

obbamna commented Nov 14, 2024

Requested changes from feedback have been filled.

I would really appreciate leniency on the -2 for late submission as I had a one week extension that was approved and the pull request was submitted before that extended due date (even earlier if you count the Monday pseudo-deadline). However, I understand if I still lose marks on late feedback.

Also, there are training graphs in images/graphs.

Thank you.

@hanemma7moud
Copy link
Collaborator

Mitchell Flaherty

@obbamna
Copy link
Author

obbamna commented Nov 17, 2024

Pull request wasn't late and feedback was applied and there are training graphs. Missing 5 Marks.

@shakes76 shakes76 added Completed and removed help wanted Extra attention is needed labels Nov 18, 2024
@shakes76
Copy link
Owner

Approved extension +2, feedback applied + 2

@shakes76 shakes76 added the Updated_Grade BB grade needs adjustment label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_After cutoff After Oct 28th BB Completed Feedback Needed Feedback needed for completion. PDF PDF submitted Preliminary Grade To be confirmed after review. _UNet2D Updated_Grade BB grade needs adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants