Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: upgrade eclipsecs-sevntu-plugin to 10.4 #941

Merged
merged 1 commit into from
Nov 28, 2022
Merged

config: upgrade eclipsecs-sevntu-plugin to 10.4 #941

merged 1 commit into from
Nov 28, 2022

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Nov 28, 2022

No description provided.

@rnveach
Copy link
Contributor Author

rnveach commented Nov 28, 2022

I did a search and did not find any other 10.0.

@rnveach
Copy link
Contributor Author

rnveach commented Nov 28, 2022 •
edited
Loading

The issue can be seen in master at https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/588778843 starting with 45ae6b1 (11 days ago)

Previous build passed which was updating the checkstyle version at 83a2bce (13 days ago)

https://github.com/checkstyle/eclipse-cs/tags
eclipse-cs released 10.4 (13 days ago)
eclipse-cs released 10.3.4 (14 days ago)

#931 (comment)
Sevntu cache was cleared somewhere around that time. I did not make a post about it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.798% when pulling 6ebe562 on rnveach:fix_eclipsecs_sevntu into e0e2035 on sevntu-checkstyle:master.

@rnveach rnveach requested a review from romani November 28, 2022 17:20
@rnveach
Copy link
Contributor Author

rnveach commented Nov 28, 2022 •
edited
Loading

I am not seeing how CI did not report the issue during the upgrade, but only after. It is possible it was a cache issue, but I am unsure.

@rnveach rnveach mentioned this pull request Nov 28, 2022
Closed
@rnveach rnveach added blocked and removed blocked labels Nov 28, 2022
@romani romani merged commit 51d0802 into sevntu-checkstyle:master Nov 28, 2022
@rnveach rnveach deleted the fix_eclipsecs_sevntu branch November 28, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnveach @coveralls @romani