Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: fails build if checkstyle versions don't match with eclipse-cs #942

Closed

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Nov 28, 2022

After looking at #941 (comment) and options, we cannot combine POMs because eclipse-cs is not in maven, this is why we always have to install it before hand.

Instead, this change will manually verify checkstyle versions match up between different POMs. Fixed the first one where the main issue was identified.

This should fail without the referenced PR merged and should pass afterwards.

@rnveach
Copy link
Contributor Author

rnveach commented Nov 28, 2022

https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/589652909#L422
There is no message, but CI failed as expected where expected. Pushed an update to see if I can get the message to display.

CI should pass when #941 is merged

@rnveach rnveach force-pushed the eclipsecs_version_matcher branch 2 times, most recently from 224647f to 4b3d8d7 Compare November 28, 2022 18:00
Comment on lines +28 to +30
ECLIPSE_CS_CS_VERSION=$(mvn -e -q -Dexec.executable='echo' \
-Dexec.args='${maven.sevntu.checkstyle.plugin.checkstyle.version}' \
--non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command is failing.

++ mvn -e -q -Dexec.executable=echo '-Dexec.args=${maven.sevntu.checkstyle.plugin.checkstyle.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec
+ ECLIPSE_CS_CS_VERSION='[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.3.1:exec (default-cli) on project net.sf.eclipsecs.parent: Command execution failed.: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.3.1:exec (default-cli) on project net.sf.eclipsecs.parent: Command execution failed.

Copy link
Contributor Author

@rnveach rnveach Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POM variable is only available on 10.3.4 . We can't use this to test the current issue since the current issue is with 10.0.0 .

Travis was not showing the issue at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command fails with 10.4.0 as well. I am not sure why.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.798% when pulling 224647f on rnveach:eclipsecs_version_matcher into e0e2035 on sevntu-checkstyle:master.

@rnveach
Copy link
Contributor Author

rnveach commented Nov 28, 2022

This won't work anyways. I am trying to pull in the verify time Checkstyle. They embed their JAR into the project, so I would need to verify a file name or something.

@rnveach rnveach closed this Nov 28, 2022
@rnveach rnveach deleted the eclipsecs_version_matcher branch November 28, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants