-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: added quarterly cache clean up for travis #931
base: master
Are you sure you want to change the base?
Conversation
Will change to quarterly after run and stats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90 might be better period to minimize downloads and keep removing old artifacts.
Is interesting here. Master is 2600 megs but this PR only reduced it to 1,000 megs (38% reduction). It is a similar savings, but I am surprised we have 1 gig of dependencies. |
f9700ed
to
fda8c3f
Compare
Done. |
https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/587535354
Rerunning to see if it is stable. |
From my local:
Haven't checked travis, but it seems like tycho is using this folder for its own purposes and doesn't realize when things are partially removed. |
Maybe it s better to just remove whole cache ones in several months( Travis cron execution) or skip eclipse from removal. |
Confirmed on my local that tycho will reset when the whole directory is deleted and not fail. It must unzip the zip file it stores there as the dates on the newly created files are 2020, so that explains why they were slated for deletion. The zip file has todays date and that is why it wasn't deleted. |
Adding https://stackoverflow.com/questions/13868821/shell-script-to-delete-directories-older-than-n-days |
fda8c3f
to
a2c8961
Compare
@@ -37,6 +37,10 @@ run-command) | |||
fi | |||
;; | |||
|
|||
quarterly-cache-cleanup) | |||
find ~/.m2 -maxdepth 4 -type d -mtime +90 -exec rm -rf {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maxdepth
is to not go too far into tycho. We can exclude a specific directory, but it doesn't seem possible to exclude it's children. So this was needed for that.
-type d
is to only target full directory deletions.
CI failure is only from same eclipse-cs test. I believe this to be the same cache issue from the first deletion attempt and it will not be fixed until the cache is manually cleared just this one time. It is not an issue from the new changes, IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge if it works and reduses something
Just blocking again until issues settle down in main repo. |
Similar to checkstyle/checkstyle#12365 (comment)