Use a different identifier for the Android tag instead of SourceContextPropertyName #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix, docs update
What is the current behavior? (You can also link to an open issue here)
The
SourceContextPropertyName
can be overwritten in some situations so the definedTag
, as described in the docs, won't work.Microsoft.Extensions.Logging.ILogger
implementationSnippet for my registration style to repro this:
What is the new behavior (if this is a feature change)?
The constant used to identify the Android TAG is changed. It is introduced as part of
Serilog.Sinks.Xamarin.Constants
Does this PR introduce a breaking change?
YES!
Users updating will need to add/update the enrich property for tag to be
Constants.AndroidTagPropertyName
Please check if the PR fulfills these requirements
Other information: