Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow restore whenever the user feels like it #723

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Allow restore whenever the user feels like it #723

merged 4 commits into from
Sep 5, 2024

Conversation

grote
Copy link
Collaborator

@grote grote commented Aug 20, 2024 •
edited
Loading

Fixes #671

@grote grote mentioned this pull request Aug 23, 2024
Merged
@grote grote mentioned this pull request Sep 2, 2024
Closed
@grote grote added this to the 3.x milestone Sep 5, 2024
@t-m-w t-m-w mentioned this pull request Sep 5, 2024
Merged
t-m-w
t-m-w reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the problem (mentioned somewhere before) that if you scroll down in the list, the "Restore backup" button disappears. You need to scroll up a little bit for it to reappear.

Video demonstrating the problem
screen-20240905-141202.webm

@grote
Copy link
Collaborator Author

grote commented Sep 5, 2024

This has the problem (mentioned somewhere before) that if you scroll down in the list

yeah, it is not really related to this PR though.

If we wouldn't hide the button when scrolling, it would overlay some ui elements that you couldn't really access then. If we'd put it permanently at the end, we'd lose precious vertical space.

@t-m-w
Copy link
Collaborator

t-m-w commented Sep 5, 2024 •
edited
Loading

This has the problem (mentioned somewhere before) that if you scroll down in the list

yeah, it is not really related to this PR though.

Fair, I confirm it inside the wizard, too. I'll open a separate issue for it if there isn't already one.

t-m-w
t-m-w previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine! Opened issue 738 for the unrelated problem.

@grote grote dismissed t-m-w’s stale review September 5, 2024 19:12

The merge-base changed after approval.

@grote grote marked this pull request as ready for review September 5, 2024 19:14
t-m-w
t-m-w previously approved these changes Sep 5, 2024
View reviewed changes
@grote grote requested a review from t-m-w September 5, 2024 19:17
@grote grote dismissed t-m-w’s stale review September 5, 2024 19:17

The merge-base changed after approval.

t-m-w
t-m-w previously approved these changes Sep 5, 2024
View reviewed changes
@grote grote dismissed t-m-w’s stale review September 5, 2024 19:22

The merge-base changed after approval.

t-m-w

This comment was marked as outdated.

Sign in to view

t-m-w

This comment was marked as outdated.

Sign in to view

@t-m-w t-m-w self-requested a review September 5, 2024 19:23
t-m-w
t-m-w approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@t-m-w t-m-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@grote grote merged commit dc9391d into seedvault-app:android14 Sep 5, 2024
1 check passed
@grote grote deleted the allow-restore branch September 5, 2024 19:24
@t-m-w t-m-w mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-m-w t-m-w t-m-w approved these changes

@chirayudesai chirayudesai Awaiting requested review from chirayudesai

@stevesoltys stevesoltys Awaiting requested review from stevesoltys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Roadmap
Development

Successfully merging this pull request may close these issues.

Allow restore after device set-up
2 participants
@grote @t-m-w