Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Material3 #729

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

theimpulson
Copy link
Collaborator

No description provided.

@theimpulson theimpulson marked this pull request as draft August 22, 2024 07:21
@grote grote added this to the 3.x milestone Sep 5, 2024
@t-m-w
Copy link
Collaborator

t-m-w commented Sep 5, 2024

Not sure if this is ready yet, since I know it's just a draft, but with #723 and this, I see some odd theming:

Screenshot 1

Screenshot showing a mismatched white background around the "Select apps to restore" heading.

Screenshot 2

Scrolled-down screenshot showing the white background now having turned a darker shade of gray than the rest of the page.

Both screenshots show the icons for "System data" as white, which is hard to see against the light gray background. It looks fine in Dark theme (not shown).

@theimpulson theimpulson marked this pull request as ready for review September 6, 2024 07:21
@grote
Copy link
Collaborator

grote commented Sep 6, 2024

Awesome, thanks!

@grote grote merged commit 10f9f8e into seedvault-app:android14 Sep 6, 2024
1 check passed
@theimpulson theimpulson deleted the material3fixes branch September 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants