Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tasks completed #12
base: main
Are you sure you want to change the base?
More tasks completed #12
Changes from 13 commits
5441791
5a8a47f
f42d3ab
3fd99ac
6b20fe0
68c5f54
bdd0cd7
8a79dfd
5462f46
4203fa9
952e27a
f06591e
368a075
b3e30b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we strengthen the None case to say that None implies that
spec_tri(i) > u32::MAX
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can, but I don't think it's very easy to prove that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be straightforward to prove that
spec_tri
is monotonic, which then means that if you locally discover that your computation ofspec_tri(x)
overflows (i.e., doesn't stay in bounds), then you can use the monotonic property to say thatspec_tri(n)
for anyn > x
would also overflow, so you're justified in returningNone