More tasks completed #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parno could you review please? |
|
Yes, I should be able to review this either tomorrow or Wednesday at the latest. |
parno
reviewed
Sep 24, 2024
| result.len() == n + 1, | ||
| forall|i: int| | ||
| #![trigger result[i]] | ||
| 0 <= i < result.len() ==> result[i].is_some() ==> result[i].unwrap() == spec_tri( |
There was a problem hiding this comment.
Could we strengthen the None case to say that None implies that spec_tri(i) > u32::MAX?
There was a problem hiding this comment.
We can, but I don't think it's very easy to prove that
There was a problem hiding this comment.
I think it should be straightforward to prove that spec_tri is monotonic, which then means that if you locally discover that your computation of spec_tri(x) overflows (i.e., doesn't stay in bounds), then you can use the monotonic property to say that spec_tri(n) for any n > x would also overflow, so you're justified in returning None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.