Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to select if poll does not exist #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fall back to select if poll does not exist #117

wants to merge 1 commit into from

Conversation

jstasiak
Copy link

@jstasiak jstasiak commented Jan 7, 2016

select.poll will be missing when Gevent (or Eventlet, soon) monkey patching is applied.

Closes: #78

@jstasiak
Fall back to select if poll does not exist
04fea85 
The explanation is in the comment in the code.

Closes: seb-m#78
This was referenced Jan 7, 2016
Closed
Open
@jstasiak
Copy link
Author

@seb-m Is there something that remains to be done in order for this patch to get merged? Thanks in advance.

@cmsalmeida
Copy link

👍

@cmsalmeida
Copy link

any expected date to do this merge?
thanks in advance

@jstasiak
Copy link
Author

jstasiak commented Mar 9, 2016

@seb-m Do I need to do something more to get this merged? Thanks in advance.

@jstasiak
Copy link
Author

Seeing as this repository seems to have been inactive lately we're likely to create a fork with this and some other pull requests merged.

@jstasiak
Copy link
Author

Our fork can be found here: https://pypi.python.org/pypi/pyinotify-smarkets

I'll leave this pull request open in case it gets a chance to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstasiak @cmsalmeida