Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if select.poll is present, switch to select.select if not #78

Open
kkurian opened this issue Jul 11, 2014 · 3 comments
Open

check if select.poll is present, switch to select.select if not #78

kkurian opened this issue Jul 11, 2014 · 3 comments
Labels
enhancement

Comments

@kkurian
Copy link

kkurian commented Jul 11, 2014

select.poll() is not supported by all platforms and so "most libraries check if select.poll() is present and switch to select.select() if it's not." [1]

The popular gevent library depends upon the above behavior and removes select.poll().

Request: In order to support gevent, check if select.poll is present and switch to select.select if it is not.
@seb-m
Copy link
Owner

seb-m commented Jul 11, 2014

I doubt I will have the time to implement it any time soon but if well abstracted il would be nice indeed.

@ghost ghost mentioned this issue Jul 29, 2015
Closed
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jan 7, 2016
@jstasiak
Fall back to select if poll does not exist
b22f460 
select.poll will be missing when Gevent (or Eventlet, soon) monkey
patchiing is applied.

Closes: seb-m#78
@jstasiak jstasiak mentioned this issue Jan 7, 2016
Open
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jan 7, 2016
@jstasiak
Fall back to select if poll does not exist
04fea85 
The explanation is in the comment in the code.

Closes: seb-m#78
@jstasiak
Copy link

jstasiak commented Jan 7, 2016

@seb-m Please let me know if #117 meets your requirements.

jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 11, 2016
@jstasiak
Fall back to select if poll does not exist
7817742 
The explanation is in the comment in the code.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 11, 2016
@jstasiak
Fall back to select if poll does not exist
cea4ed6 
The explanation is in the comment in the code.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 11, 2016
@jstasiak
Use selectors module instead of poll directly
3ac45db 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 11, 2016
@jstasiak
Use selectors module instead of poll directly
e4e804e 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 11, 2016
@jstasiak
Use selectors module instead of poll directly
c020fe3 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 13, 2016
@jstasiak
Use selectors module instead of poll directly
9ecacef 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Closes: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 13, 2016
@jstasiak
Use selectors module instead of poll directly
cbc9c57 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Related: seb-m#78
jstasiak added a commit to smarkets/pyinotify-smarkets that referenced this issue Jun 13, 2016
@jstasiak
Use selectors module instead of poll directly
fe83134 
selectors provides implementation-indepandent interface to interact with
various IO multiplexing methods. Using poll directly means that the code
would fail if select.poll was missing (for example with gevent or Eventlet
monkey patching enabled) while selectors.DefaultSelector can be depended
on to be present.

Related: seb-m#78
@jstasiak jstasiak mentioned this issue Jun 13, 2016
Merged
@jstasiak
Copy link

@kkurian As this repository seems unmaintained we've created a fork[1](note: it requires Python 3.5+), the fork fixes the issue you describe here.

[1] https://pypi.python.org/pypi/pyinotify-smarkets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jstasiak @kkurian @seb-m