Reactivity Fix #1011

korgon · 2024-03-15T06:00:06Z

changed result.display from updating / merging display, to using a getter for display
result.display computed change resulted in addition of a "mask" to create display
fixed bug in variant selection, selection will now use previouslySelected value
added tests for mask, display and variants code
added E2E test for middleware to help prevent reactivity regressions when using result.display

…ing variant and middleware test

dkonieczek · 2024-03-15T17:52:23Z

Looks like previouslySelected functionality isn't working. To be further tested on Monday

korgon · 2024-03-18T16:48:59Z

Previously selected functionality cleared up.

fix(store-mobx/resultstore): modifying display to leverage mask - add…

0eaffd8

…ing variant and middleware test

korgon requested review from dkonieczek and chrisFrazier77 March 15, 2024 06:00

korgon self-assigned this Mar 15, 2024

korgon linked an issue Mar 15, 2024 that may be closed by this pull request

Reactivity and result.display #1009

Closed

chrisFrazier77 approved these changes Mar 18, 2024

View reviewed changes

dkonieczek approved these changes Mar 18, 2024

View reviewed changes

korgon merged commit dbc631d into develop Mar 18, 2024
1 check passed

korgon deleted the result-display-reactivity branch March 18, 2024 16:57

Provide feedback