Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivity and result.display #1009

Closed
korgon opened this issue Mar 12, 2024 · 1 comment · Fixed by #1011
Closed

Reactivity and result.display #1009

korgon opened this issue Mar 12, 2024 · 1 comment · Fixed by #1011
Assignees
@korgon
Labels
critical Should be fixed ASAP type: bug Something isn't working

Comments

@korgon
Copy link
Contributor

korgon commented Mar 12, 2024 •
edited
Loading

The result.display property in the SearchResultStore was recently added, but it does not properly respond to mappings changed on the result itself, instead it relies upon changes being made via the updateDisplay function. For sites using middleware to mutate the result array, certain Snap library components using the display will not re-render as expected.
@korgon korgon added type: bug Something isn't working critical Should be fixed ASAP labels Mar 12, 2024
@korgon korgon self-assigned this Mar 12, 2024
@korgon korgon linked a pull request Mar 15, 2024 that will close this issue
Reactivity Fix #1011
Merged
@korgon
Copy link
Contributor Author

korgon commented Mar 18, 2024

Released in v0.52.2

@korgon korgon closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korgon korgon

Labels
critical Should be fixed ASAP type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reactivity Fix searchspring/snap
1 participant
@korgon