Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pyrobosim_ros and pyrobosim_msgs packages into separate repos #224

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: 'true'
- uses: actions/setup-python@v5
- uses: pre-commit/[email protected]
4 changes: 4 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
steps:
- name: Check out repository
uses: actions/checkout@v4
with:
submodules: 'true'
- name: Login to Docker Hub Registry
uses: docker/login-action@v3
with:
Expand Down Expand Up @@ -96,6 +98,8 @@ jobs:
steps:
- name: Check out repository
uses: actions/checkout@v4
with:
submodules: 'true'
- name: Login to Docker Hub Registry
uses: docker/login-action@v3
with:
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "pyrobosim_ros"]
path = pyrobosim_ros
url = https://github.com/sea-bass/pyrobosim_ros.git
12 changes: 9 additions & 3 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,23 @@ version: 2

# Set the version of Python and other tools
build:
os: ubuntu-22.04
os: ubuntu-24.04
tools:
python: "3.10"
python: "3.12"

# Ensure the ROS related submodules are included
submodules:
include:
- pyrobosim_ros
recursive: true

python:
install:
- requirements: docs/python_docs_requirements.txt
- method: pip
path: pyrobosim
- method: pip
path: pyrobosim_ros
path: pyrobosim_ros/pyrobosim_ros

# Build documentation in the Sphinx source directory
sphinx:
Expand Down
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
author = "Sebastian Castro"

# The full version, including alpha/beta/rc tags
version = release = "2.0.0"
version = release = "3.0.0"


# -- General configuration ---------------------------------------------------
Expand Down
19 changes: 17 additions & 2 deletions docs/source/setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,23 @@ However, note that this will not include any of the ROS 2 or Task and Motion Pla
Local Setup
-----------

If using ROS 2, clone this repo in a valid `ROS 2 workspace <https://docs.ros.org/en/jazzy/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.html>`_.
Otherwise, if running standalone, clone it wherever you would like.
If running standalone, clone this repo wherever you would like.

::

git clone https://github.com/sea-bass/pyrobosim_ros.git

.. note::
If using ROS 2, clone this repo in a valid `ROS 2 workspace <https://docs.ros.org/en/jazzy/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.html>`_.

Also, make sure to **include submodules**, as this is how the `ROS 2 interface <https://github.com/sea-bass/pyrobosim_ros>`_ is included.

::

mkdir -p ~/my_workspace/src
cd ~/my_workspace/src
git clone --recurse-submodules https://github.com/sea-bass/pyrobosim_ros.git


To set up your Python virtual environment, configure and run

Expand Down
2 changes: 1 addition & 1 deletion pyrobosim/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_files_in_folder(directory):

setup(
name=project_name,
version="2.0.0",
version="3.0.0",
url="https://github.com/sea-bass/pyrobosim",
author="Sebastian Castro",
author_email="[email protected]",
Expand Down
47 changes: 0 additions & 47 deletions pyrobosim_msgs/CMakeLists.txt

This file was deleted.

13 changes: 0 additions & 13 deletions pyrobosim_msgs/action/ExecuteTaskAction.action

This file was deleted.

15 changes: 0 additions & 15 deletions pyrobosim_msgs/action/ExecuteTaskPlan.action

This file was deleted.

11 changes: 0 additions & 11 deletions pyrobosim_msgs/msg/ActionExecutionOptions.msg

This file was deleted.

37 changes: 0 additions & 37 deletions pyrobosim_msgs/msg/ExecutionResult.msg

This file was deleted.

7 changes: 0 additions & 7 deletions pyrobosim_msgs/msg/GoalPredicate.msg

This file was deleted.

4 changes: 0 additions & 4 deletions pyrobosim_msgs/msg/GoalSpecification.msg

This file was deleted.

9 changes: 0 additions & 9 deletions pyrobosim_msgs/msg/LocationState.msg

This file was deleted.

9 changes: 0 additions & 9 deletions pyrobosim_msgs/msg/ObjectState.msg

This file was deleted.

3 changes: 0 additions & 3 deletions pyrobosim_msgs/msg/Path.msg

This file was deleted.

13 changes: 0 additions & 13 deletions pyrobosim_msgs/msg/RobotState.msg

This file was deleted.

20 changes: 0 additions & 20 deletions pyrobosim_msgs/msg/TaskAction.msg

This file was deleted.

5 changes: 0 additions & 5 deletions pyrobosim_msgs/msg/TaskPlan.msg

This file was deleted.

5 changes: 0 additions & 5 deletions pyrobosim_msgs/msg/WorldState.msg

This file was deleted.

26 changes: 0 additions & 26 deletions pyrobosim_msgs/package.xml

This file was deleted.

6 changes: 0 additions & 6 deletions pyrobosim_msgs/srv/RequestWorldState.srv

This file was deleted.

10 changes: 0 additions & 10 deletions pyrobosim_msgs/srv/SetLocationState.srv

This file was deleted.

1 change: 1 addition & 0 deletions pyrobosim_ros
Submodule pyrobosim_ros added at 19d599
Loading
Loading