Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pyrobosim_ros and pyrobosim_msgs packages into separate repos #224

Closed
wants to merge 5 commits into from

Conversation

sea-bass
Copy link
Owner

@sea-bass sea-bass commented Jul 25, 2024

This PR moves the pyrobosim_ros and pyrobosim_msgs packages into a separate repo (https://github.com/sea-bass/pyrobosim_ros), including them back here as submodules.

This will facilitate creating releases that officially work within the ROS 2 ecosystem. See

Also updating the release to 3.0.0 as this is the last of the big changes before I try cutting a major release.

@sea-bass sea-bass linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 25, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
core
   __init__.py90100% 
   dynamics.py430100% 
   gazebo.py136894%55, 124, 230, 244–248
   hallway.py92891%192, 234–237, 261–263
   locations.py1302183%66, 68, 84, 99–100, 102, 113–114, 116–117, 134, 192, 207, 232, 242, 287, 298–299, 301–302, 331
   objects.py69494%78, 106, 137, 197
   robot.py3886583%237–238, 250–251, 263, 266, 270–271, 276–277, 307–310, 315–318, 325–326, 350, 394–397, 401–403, 437, 439, 475–476, 478–479, 496–498, 564–566, 675, 711, 728, 742–743, 745, 747, 750–752, 765, 773, 779, 785, 791, 803, 846, 864, 867, 872, 885–889
   room.py48197%113
   world.py73518674%147–148, 184–185, 189, 242–243, 245–246, 274–275, 298–300, 337–339, 351–353, 382–384, 409–411, 464, 478–479, 481–482, 497–499, 515–519, 521–523, 525–526, 529, 533–537, 540–542, 545–556, 572–573, 591–593, 607–609, 645–647, 659–661, 683–685, 710–712, 760–761, 764, 780, 810–811, 822, 825, 833, 849–853, 855–857, 860–861, 864–867, 869, 872, 874–876, 878–880, 882, 897, 904, 915–919, 954–955, 959–960, 978–979, 985–986, 988–989, 991, 993–994, 996, 998–999, 1009–1010, 1013, 1015, 1029, 1031, 1038, 1085, 1116–1117, 1128, 1139–1141, 1143–1146, 1148, 1165–1166, 1170–1171, 1206–1207, 1209, 1226–1227, 1258, 1272–1275, 1287–1290, 1304, 1315–1316, 1318, 1362–1363, 1415, 1495–1496
   yaml_utils.py1081189%64, 68, 153–155, 159–160, 180–181, 200–201
gui
   __init__.py20100% 
   main.py1913084%22–24, 45, 77–78, 196, 208–212, 219–222, 224, 227–233, 237, 242–243, 247–248, 259
   world_canvas.py2835580%44–45, 47–51, 54, 62–63, 171–174, 181, 183, 240–242, 289, 326, 360–361, 384–385, 387, 389–391, 394–397, 399, 403–409, 412, 415–416, 431–433, 436, 453, 496, 517, 521, 544, 561, 575
manipulation
   __init__.py10100% 
   grasping.py2366174%102, 110–112, 114–122, 124, 132, 462, 464–466, 470–472, 566–568, 571–575, 583, 586–588, 593–594, 600–604, 607–614, 617–619, 628, 630, 632–638
navigation
   __init__.py30100% 
   a_star.py781087%67–72, 74–76, 165
   execution.py85692%72–74, 79–81
   occupancy_grid.py1391489%44–47, 49–53, 56, 192, 226, 234, 238
   path_planner.py26676%33, 36, 38, 42, 89, 94
   planner_base.py591771%29–35, 51, 57–59, 142–147
   prm.py72297%61–62
   rrt.py1740100% 
   world_graph.py70395%118, 121, 145
planning
   __init__.py00100% 
   actions.py1120100% 
planning/pddlstream
   __init__.py7185%13
   default_mappings.py90100% 
   planner.py40880%119–126
   primitives.py57296%68, 208
   utils.py85396%66, 99–100
utils
   __init__.py00100% 
   general.py33487%23, 45, 51–52
   knowledge.py1542285%86, 117, 156–161, 163–164, 167–168, 170–173, 189, 204, 208, 250, 266, 329
   motion.py650100% 
   polygon.py1110100% 
   pose.py890100% 
   search_graph.py93396%240–242
   trajectory.py67198%165
TOTAL409955286% 

Tests Skipped Failures Errors Time
196 0 💤 0 ❌ 0 🔥 3m 4s ⏱️

@sea-bass sea-bass marked this pull request as ready for review July 25, 2024 02:07
@sea-bass
Copy link
Owner Author

@DLu what do you think?

Copy link
Collaborator

@eholum eholum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submodules, my oldest and dearest friend.

So functionally this is fine, I did a quick sanity check and the docs updates look good! But dumb question - is this out of necessity or desire for separation? What exactly is going to break in the bloom process if you just kept this as folders/subfolders?

@sea-bass
Copy link
Owner Author

Submodules, my oldest and dearest friend.

So functionally this is fine, I did a quick sanity check and the docs updates look good! But dumb question - is this out of necessity or desire for separation? What exactly is going to break in the bloom process if you just kept this as folders/subfolders?

Hmm... you're right. Maybe we can just keep it all here and still go through the whole release process.

There are still a few places in the pyrobosim_ros/CMakeLists.txt where we're currently pointing to source code in other folders, but as I found yesterday that's not necessary. So we can at least delete that part and keep the repo as is.

Let me sleep on it for a bit, but great point, as I would love to not have to maintain two separate repos.

@sea-bass
Copy link
Owner Author

OK yeah let's not do this. Good bye, PR, and thanks again @eholum!

@sea-bass sea-bass closed this Jul 26, 2024
@eholum
Copy link
Collaborator

eholum commented Jul 26, 2024

Lol. Always happy to have my ignorance lead to less work!

Edit: whoops. Fat phone fingers...

@eholum eholum reopened this Jul 26, 2024
@eholum eholum closed this Jul 26, 2024
@sea-bass sea-bass deleted the split-repos branch July 26, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate ROS and Python packages
2 participants