Add support for x86 MSI and IOAPIC IRQs #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Velickovic
commented
Feb 20, 2024
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
from
0dfacf0 to
46bc023
Compare
Ivan-Velickovic
commented
Feb 20, 2024
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
4 times, most recently
from
6ab0992 to
01ebf09
Compare
Ivan-Velickovic
commented
Feb 20, 2024
| &cslot_to_relative_cptr(slot), | ||
| )?; | ||
| } | ||
| #[sel4_cfg(any(ARCH_IA32, ARCH_X86_64))] |
There was a problem hiding this comment.
Did this because #[sel4_cfg(ARCH_X86_64)] doesn't work currently
There was a problem hiding this comment.
Can you clarify what change is this comment about?
There was a problem hiding this comment.
Sorry, I made a typo in my comment. I meant that it would be better to do a generic x86 (by checking CONFIG_ARCH_X86) check but that doesn't work at this moment due to
rust-sel4/crates/sel4/src/arch/mod.rs
Line 10 in d3341ea
nspin
requested changes
Feb 20, 2024
| &cslot_to_relative_cptr(slot), | ||
| )?; | ||
| } | ||
| #[sel4_cfg(any(ARCH_IA32, ARCH_X86_64))] |
There was a problem hiding this comment.
Can you clarify what change is this comment about?
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
from
01ebf09 to
b8a6013
Compare
nspin
requested changes
Feb 21, 2024
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
2 times, most recently
from
85ce186 to
8074452
Compare
nspin
reviewed
Feb 21, 2024
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
from
8074452 to
ec50d02
Compare
Signed-off-by: Ivan Velickovic <[email protected]>
Ivan-Velickovic
force-pushed
the
x86_irqs
branch
from
ec50d02 to
0d70d98
Compare
|
I think it's ready to go now. |
|
Thanks! |
nspin
approved these changes
Feb 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on coliasgroup/capdl#1.