provide a NUM_DOMAINS test override #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the environment variable INPUT_NUM_DOMAINS will cause the build to override the KernelNumDomains setting in the config file with the provided setting. Signed-off-by: Gerwin Klein <[email protected]>
lsf37
force-pushed
the
num-domains-override
branch
from
c1db711 to
697fbe4
Compare
This will now test with the following num_domains settings: - PRs: default as in config file, no matrix - push to master: with NUM_DOMAINS = 1 and default (= '') - weekly test: with NUM_DOMAINS = 1, 7, and default The default in the current config files is 16. 1 leads to structural code changes is the setting most likely to break. 7 is for checking that the proofs also work with a value that is not a power of 2. Signed-off-by: Gerwin Klein <[email protected]>
lsf37
force-pushed
the
num-domains-override
branch
from
697fbe4 to
2114b79
Compare
lsf37
added
CI
Signed-off-by: Gerwin Klein <[email protected]>
|
I'm somewhat confused, where does NUM_DOMAINS and INPUT_NUM_DOMAINS meet up? At the github level, NUM_DOMAINS is set, but then in scripts, INPUT_NUM_DOMAINS is read. |
Xaphiosis
approved these changes
Dec 11, 2023
This is a GitHub thing: workflow input names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the environment variable
INPUT_NUM_DOMAINSwill cause the build to override theKernelNumDomainssetting in the config file with the provided setting.INPUT_NUM_DOMAINSis the name we get from the GitHub workflow input with the nameNUM_DOMAINS.The second commit switches the test to the following
NUM_DOMAINSsettings:The default is 16 in the current config files. 1 leads to structural code changes is the setting most likely to break. 7 is for checking that the proofs also work with a value that is not a power of 2.
This needs seL4/ci-actions#293 to be merged first.