Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-proofs: provide optional NUM_DOMAINS override #293

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Dec 10, 2023

If the NUM_DOMAINS input is set, the proof build system will override the KernelNumDomains setting. We make the NUM_DOMAINS value part of the cache key so that we get fast proofs on master for things that already had a successful test on a pull request.

If the NUM_DOMAINS input is set, the proof build system will override
the KernelNumDomains setting. We make the NUM_DOMAINS value part of
the cache key so that we get fast proofs on master for things that
already had a successful test on a pull request.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 self-assigned this Dec 10, 2023
@lsf37 lsf37 added the verification actions related to proofs and l4v label Dec 10, 2023
@lsf37 lsf37 requested a review from Xaphiosis December 10, 2023 11:09
@Xaphiosis
Copy link
Member

see my question on seL4/l4v#701 ... once that's cleared up, I'll approve both.
Might get a bit expensive testing master twice on every commit, but it's probably the right way to do it for now.

@lsf37 lsf37 merged commit 12bb970 into master Dec 11, 2023
7 checks passed
@lsf37 lsf37 deleted the num-domains branch December 11, 2023 07:06
@lsf37
Copy link
Member Author

lsf37 commented Dec 11, 2023

see my question on seL4/l4v#701 ... once that's cleared up, I'll approve both. Might get a bit expensive testing master twice on every commit, but it's probably the right way to do it for now.

Yeah, if the spend goes up too much we might need to switch to weekly. Let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verification actions related to proofs and l4v
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants