camkes-vm: fix typo in settings key string #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Axel Heider <[email protected]>
This was referenced Jan 26, 2024
lsf37
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Wow, thanks for that. I wonder why this ever worked, actually.
Maybe some checking for the presence of unknown keys would be good after all (then this would have shown up). We'd need something that builds.py implements as a base and every check can extend with its own keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another typo, which seems to be the reasons some CAmkES VM hardware test fail - they just don't run what they are supposed to run. We have a successful test now: https://github.com/seL4/camkes-vm-examples/actions/runs/7671627886/job/20910564830?pr=59