Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zynqmp 2018 3 #123

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Zynqmp 2018 3 #123

merged 2 commits into from
Jan 28, 2024

Conversation

chrisguikema
Copy link
Contributor

@chrisguikema chrisguikema commented Jan 25, 2024

Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Should this also have a CI run then?

@chrisguikema
Copy link
Contributor Author

Should this also have a CI run then?

My thought is to make an update to the ci-actions repo to add a target for each Petalinux version

@axel-h
Copy link
Member

axel-h commented Jan 26, 2024

My thought is to make an update to the ci-actions repo to add a target for each Petalinux version

With the fix from seL4/ci-actions#316 passing that as parameter should work then.

The seL4 kernel uses an older device tree. In order to make the kernel
device tree compatible with the VMM device tree generation, older
Linux artifacts are needed. This commit makes 2018.3 the default, with
the option for users to use newer artifacts if needed.

Signed-off-by: Chris Guikema <[email protected]>
@lsf37 lsf37 self-requested a review January 28, 2024 04:04
@axel-h
Copy link
Member

axel-h commented Jan 28, 2024

Seems good to merge. We see the test failures because seL4/camkes-vm-examples#57 need to be rebased to master to pick up the fixed for vm_introspect from seL4/camkes-vm-examples#39

@axel-h axel-h added the hw-test camkes-vm-examples hardware builds + runs for this PR label Jan 28, 2024
@axel-h
Copy link
Member

axel-h commented Jan 28, 2024

I've rebased seL4/camkes-vm-examples#57 and the basline builds pass now. So we could merge this PR now to have a dependency of the other PRs in. What remains is making the ping examples work on the ZCU102. The run still fails, see #124

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with merging this part now.

@lsf37 lsf37 merged commit 2023934 into seL4:master Jan 28, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw-test camkes-vm-examples hardware builds + runs for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants