-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make DefineCAmkESVMFileServer() more flexible #31
Conversation
Need to investigate and fix the failing tests... |
Don't bother, I think I have a clue what fails there and what I have to improve to make it work. Just need to find some time to work in this again. |
Could I get some feedback here, any chances to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! The ability to set CPIO output paths introduced in seL4/seL4_tools#151 will need to be merged before the second commit here can be merged.
Adding a feature that allows an empty file string also in |
Adding support for file lists as parameter also, because this comes handy for the existing examples. |
0a858c7
to
81a19b2
Compare
Avoid creating some unnecessary intermediate helper CMake targets. |
e29c75b
to
9fdb072
Compare
Changed the order of the commits and split them up further. That allows cherry-picking the CPIO custom folder feature without taking the change in the CMake FileServer functions. |
Removing the dependency of this PR on seL4/seL4_tools#151 and seL4/camkes-vm-examples#37. It's not necessary to use a specific folder, if the instance name is simply used in the file name of the archive and lib. I will make another PR to move the build artifact out out of the build root folder, so this does not block this PR. |
2078b78
to
c98e3de
Compare
3c51daf
to
8349314
Compare
Create dedicated targets for each file server instances, and set the properties for fixed names within each target. This is cleaner than putting everything into a single |
e780d10
to
b5208df
Compare
- Define variables to hold the actual names. - Add comments about he steps Signed-off-by: Axel Heider <[email protected]>
- allow custom type and instance names - allow passing files for DefineCAmkESVMFileServer(), this avoids calling AddToFileServer() - AddToFileServer() becomes just a light wrapper - use instance specific name for archive and lib - remove the target vm_fserver_config, as it obsolete now Signed-off-by: Axel Heider <[email protected]>
Can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the dependency on seL4/seL4_tools#151 is gone, I think we can merge this one, yes.
DefineCAmkESVMFileServer()
, this avoids callingAddToFileServer()
AddToFileServer()
becomes just a light wrapperThis allows doing customizing the file server component name and doing all in one call:
See seL4/camkes-vm-examples#37 for a usage examples.