Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: use params for DefineCAmkESVMFileServer() #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Mar 22, 2023

Use the new version of DefineCAmkESVMFileServer() that accpts files as parameters. This allows doing everything in one call.

This needs at least seL4/camkes-vm#31 to get the functionality, but must also work with seL4/camkes-vm#76 that removes the obsolete CMake function AddToFileServer().

Test with: seL4/camkes-vm#76, seL4/seL4_tools#151

@axel-h axel-h force-pushed the patch-axel-3 branch 2 times, most recently from 1569dc6 to 764b64d Compare March 22, 2023 20:15
@axel-h axel-h force-pushed the patch-axel-3 branch 6 times, most recently from c4726df to 26ea104 Compare March 23, 2023 13:21
@axel-h axel-h force-pushed the patch-axel-3 branch 2 times, most recently from a9937d1 to 9c5e914 Compare March 23, 2023 18:00
@axel-h axel-h marked this pull request as draft March 23, 2023 18:00
@axel-h axel-h force-pushed the patch-axel-3 branch 2 times, most recently from d1e6a05 to d0850ae Compare March 25, 2023 02:44
@axel-h axel-h marked this pull request as ready for review March 25, 2023 02:52
@axel-h axel-h force-pushed the patch-axel-3 branch 4 times, most recently from 45fb398 to 91b2346 Compare May 5, 2023 16:44
@axel-h
Copy link
Member Author

axel-h commented May 5, 2023

Can we merge this, now that seL4/camkes-vm#31 has been merged?

Note that As a side effect, this stops using the CMake wrapper function DeclareCAmkESVMRootServer() now, as it lacks the options to pass the necessary file server parameters. In the long run, I think it would be worth deprecating this wrapper function and require all projects calling DefineCAmkESVMFileServer() and DeclareCAmkESRootserver() explicitly in their CMake files. It is a bit less convenient, but it makes it much more more transparent, what is really happening.
The alternative would be giving the wrapper DeclareCAmkESVMRootServer() more file server parameters. But I do not think going is road is really helpful, as this causes a convenience function to get overloaded with parameters, which all need to be explained again and could be more confusing in the end.

@axel-h axel-h force-pushed the patch-axel-3 branch 6 times, most recently from 53f9aa8 to 61c1b4b Compare January 24, 2024 10:13
@axel-h axel-h force-pushed the patch-axel-3 branch 5 times, most recently from 2ffde46 to c41b312 Compare January 28, 2024 22:22
@axel-h axel-h added the hw-build hardware builds for this PR label Jan 28, 2024
@axel-h axel-h force-pushed the patch-axel-3 branch 6 times, most recently from b4c12e4 to 33b1b86 Compare January 29, 2024 17:34
@axel-h axel-h added hw-test hardware builds + runs for this PR and removed hw-build hardware builds for this PR labels Jan 29, 2024
@axel-h axel-h force-pushed the patch-axel-3 branch 8 times, most recently from 0c49f19 to e8c003c Compare January 31, 2024 23:24
@axel-h axel-h added hw-build hardware builds for this PR and removed hw-test hardware builds + runs for this PR labels Feb 23, 2024
Axel Heider added 3 commits March 16, 2024 23:39
Signed-off-by: Axel Heider <[email protected]>
- avoid calling AddToFileServer(), build the file list as CMake variable
  instead.
- clean up the CMake target dependencies, avoid explicit references
  to (helper) targets, when this is not necessary.

Signed-off-by: Axel Heider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hw-build hardware builds for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant