-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reader for Stereo-seq files. #70
Conversation
for more information, see https://pre-commit.ci
…ldata-io into Stereo-seq_reader
file format description @LucaMarconato https://github.com/STOmics/SAW/tree/main/Documents/FileFormat |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 41.92% 36.98% -4.94%
==========================================
Files 16 17 +1
Lines 854 1352 +498
==========================================
+ Hits 358 500 +142
- Misses 496 852 +356
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ldata-io into Stereo-seq_reader
for more information, see https://pre-commit.ci
…ldata-io into Stereo-seq_reader
for more information, see https://pre-commit.ci
…ldata-io into Stereo-seq_reader
@LLehner @LucaMarconato how is this looking? should we merge? |
fantastic, what is the blocker? |
aggregation of e.g. image channels over segmentation masks doesn't work yet, perhaps the segmentation mask isn't properly linked to the table. Also plotting with rendering shapes doesn't work yet. |
Is the plotting an issue in |
I looked into the points 3 and 4 from #97.
In addition to solving the above, I would also like to address the following points:
Finally, we will be working on a rasterization-based approach for rendering large collections of bins. This will come after this PR is merged, but when available, will improve the user experience around Stereo-seq data. |
Many thanks for your work! To my knowledge there is no cell identifier associated with each cell in the raw data or at least we have not used one so far. I would proceed as suggested with arbitrary labeling! |
for more information, see https://pre-commit.ci
…ldata-io into Stereo-seq_reader
I fixed all the points above, with the exception to the parsing of the labels, which I now parse as an image with two colors instead of as a labels, to avoid confusion. I have tried using I will polish the code and make a short example notebook, after this we are good to merge. |
I prepared and uploaded the notebook here; I removed the outputs because the data is not currently public. The notebook is affected by two bugs of spatialdata-plot, that I tracked here and here. The visualization work with napari-spatialdata. @timtreis since you have the data locally, could you please have a look at them? Anyway, since the bugs are not in spatialdata-io, now the PR is ready to merge! Thanks all for the work! 🚀 |
Add reader for Stereo-seq files.
TODO:
counts_per_cell
present in .obs?table.obsm["cellBorder"]