Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dendrogram implementation to aggregate #3204

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

flying-sheep
Copy link
Member

  • Release notes not necessary because:

@flying-sheep flying-sheep changed the title WIP dendrogram impl with aggregate Switch dendrogram implementation to aggregate Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.10%. Comparing base (c6766d7) to head (3a9b3f6).

Files Patch % Lines
src/scanpy/tools/_dendrogram.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3204      +/-   ##
==========================================
- Coverage   76.63%   74.10%   -2.54%     
==========================================
  Files         109      109              
  Lines       12533    12537       +4     
==========================================
- Hits         9605     9290     -315     
- Misses       2928     3247     +319     
Files Coverage Δ
src/scanpy/_compat.py 78.26% <100.00%> (+0.48%) ⬆️
src/scanpy/tools/_dendrogram.py 65.30% <83.33%> (-21.66%) ⬇️

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sc.tl.dendrogram no longer(?) works in backed mode
1 participant