-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): cache arrays in BaseCompressedSparseDataset
#1744
base: main
Are you sure you want to change the base?
Conversation
ilan-gold
commented
Nov 8, 2024
•
edited
Loading
edited
- Noticed while creating the screenshot tutorial for the announcement
- Tests added
- Release note added (or unnecessary)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
- Coverage 87.01% 84.55% -2.46%
==========================================
Files 40 40
Lines 6059 6075 +16
==========================================
- Hits 5272 5137 -135
- Misses 787 938 +151
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it promises and has nice tests.
However I think Isaac only cached the longest array intentionally. I forgot the reason though.
Sure, we now have much bigger data so maybe if there was a tradeoff, things are now different. But maybe worth checking.
We only cached As for the other arrays, I don't think there was a good reason - I think we wanted to just start with that but I posted on zulip. |
(I was the one who started doing the caching) |
Hm, since these arrays are storage classes anyway, and probably don’t cost any noticable amount of memory, I don‘t foresee a problem. |
Let's review this in the absence of an answer |
(Or rather, give approval since you already seem to have reviewed) |