Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on flattening X #172

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Warn on flattening X #172

merged 2 commits into from
Jul 4, 2019

Conversation

ivirshup
Copy link
Member

@ivirshup ivirshup commented Jun 30, 2019

In response to #171 (comment)

Throw a warning if X is flattened prior to returning, since that behavior will change in v0.7.

@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #172 into master will increase coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   78.82%   78.85%   +0.02%     
==========================================
  Files          12       12              
  Lines        2102     2109       +7     
==========================================
+ Hits         1657     1663       +6     
- Misses        445      446       +1
Impacted Files Coverage Δ
anndata/compat.py 29.62% <100%> (+8.79%) ⬆️
anndata/core/anndata.py 79.38% <80%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffd8c6...4d2aba1. Read the comment docs.

@falexwolf
Copy link
Member

Perfect! 😄

@ivirshup ivirshup merged commit 19bd221 into scverse:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants