Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaseCompressedSparseDataset.group type annotation #1415

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Mar 12, 2024

Workaround will be unnecessary once theislab/scanpydoc#140 is fixed.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.20%. Comparing base (f9eefcf) to head (ea051f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
- Coverage   86.31%   84.20%   -2.11%     
==========================================
  Files          36       36              
  Lines        5610     5610              
==========================================
- Hits         4842     4724     -118     
- Misses        768      886     +118     
Flag Coverage Δ
gpu-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
anndata/_core/sparse_dataset.py 94.62% <100.00%> (ø)

... and 7 files with indirect coverage changes

@flying-sheep flying-sheep added this to the 0.10.7 milestone Mar 12, 2024
@flying-sheep flying-sheep merged commit 765fabc into main Mar 12, 2024
16 of 26 checks passed
@flying-sheep flying-sheep deleted the fix-group-storage-type branch March 12, 2024 14:16
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Mar 12, 2024
flying-sheep added a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add working GroupStorageType type annotation
1 participant