Allow for specifying a tensor device in AnnLoader #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinv11
force-pushed
the
annloader_custom_device
branch
from
dd8547e
to
b953702
Compare
austinv11
force-pushed
the
annloader_custom_device
branch
from
bf328b1
to
91f66fb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
- Coverage 85.27% 83.00% -2.27%
==========================================
Files 34 34
Lines 5404 5408 +4
==========================================
- Hits 4608 4489 -119
- Misses 796 919 +123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently AnnLoader only supports transferring tensors to cuda devices. However, PyTorch as of late has much improved its support of other devices such as mps (Mac GPUs) and XLA (Google TPUs). So I added a device argument that is more semantically similar to other PyTorch APIs to defer to the user to decide which accelerator device (if any) to load the data onto.