-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shape inference for X=None #1121
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
- Coverage 84.75% 82.68% -2.07%
==========================================
Files 36 36
Lines 5149 5153 +4
==========================================
- Hits 4364 4261 -103
- Misses 785 892 +107
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor changes, otherwise good.
For the subsetting + views, I think I was concerned about aligned mappings + raw with various kinds of subsetting.
.X
to be None #467TODO:
unclear if that’s covered @ivirshup can you clarify the scope of this?
Later:
to_csvs