-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing .X
to be None
#467
Comments
@rcannood which of the above points have been adressed by your PR? |
To begin:
There are also some basic checks for 'Views', but not everything mentioned above has been taken care of so it's still WIP. |
I've fixed up many of these cases in #677. I think |
Adding a point to the checklist: Gotta figure out what the shape of the object is when X is None. Currently we figure out the shape of an AnnData by checking the shapes of An interesting question is what happens if you only provide elements aligned to one axis. E.g. just Is this allowed? adata = AnnData(obs=obs) Then what is adata.varm["x"] = np.ones((20, 10)) |
We think this is probably closable but we need to verify |
Tracking issue for allowing
X
to beNone
.When parts get ticked off they should be marked with the PR that fixed them.
TODO:
All of these need tests, some of them may already work.
.X = None
doesn't change other view behavior,a[idx].X
doesn't do anything weird, and copying views still works)_subset_inplace
(25bbf8a)X
is NoneX
areNone
#678X
, e.g.obs_vector
,to_df
. (Improve support for X=none #677)zarr
,hdf5
) Improve support for X=none #677to_csvs
There is a bit of ordering to do here.
The text was updated successfully, but these errors were encountered: